feat(asb): authenticate the JSON-RPC server with a hashed password#1099
Merged
Conversation
binarybaron
force-pushed
the
feat/asb-rpc-auth
branch
from
97dcd0b to
e2143ae
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
binarybaron
force-pushed
the
feat/asb-rpc-auth
branch
from
e2143ae to
8d5e7af
Compare
binarybaron
force-pushed
the
feat/asb-rpc-auth
branch
4 times, most recently
from
2c6e444 to
e0f5fb7
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e0f5fb7. Configure here.
binarybaron
force-pushed
the
feat/asb-rpc-auth
branch
3 times, most recently
from
e554d98 to
3ef25ca
Compare
The ASB verifies a Bearer password against a salt:hmac HMAC-SHA256 verifier read from --rpc-auth-file (mandatory when the RPC server is enabled). asb-controller prompts for the password on startup and verifies before granting access. The orchestrator gains a gen-rpc-auth command to produce the keyfile and mounts it into the asb container.
binarybaron
force-pushed
the
feat/asb-rpc-auth
branch
from
3ef25ca to
0bf60b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.