Skip to content

feat: npsim 1.5.0, patch dd4hep warning for Geant4TVUserParticleHandler#257

Open
veprbl wants to merge 2 commits into
masterfrom
pr/dd4hep_TC_error_for_epic
Open

feat: npsim 1.5.0, patch dd4hep warning for Geant4TVUserParticleHandler#257
veprbl wants to merge 2 commits into
masterfrom
pr/dd4hep_TC_error_for_epic

Conversation

@veprbl
Copy link
Copy Markdown
Member

@veprbl veprbl commented Apr 27, 2026

Copilot AI review requested due to automatic review settings April 27, 2026 17:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the pinned eic/eic-spack revision used by this repository, in order to pick up upstream changes (per linked eic-spack PR #896).

Changes:

  • Bump EICSPACK_VERSION commit hash in eic-spack.sh.

@veprbl veprbl requested a review from DraTeots April 27, 2026 20:06
@eic eic deleted a comment from Copilot AI Apr 28, 2026
@veprbl veprbl changed the title dd4hep: display compatibility notice when older geometry is used with Geant4TVUserParticleHandler feat: npsim 1.5.0, patch dd4hep warning for Geant4TVUserParticleHandler Apr 28, 2026
@veprbl veprbl enabled auto-merge (squash) April 28, 2026 14:44
@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented Apr 28, 2026

Continuing the last discussion in eic/epic#1081

# capybara capy rev head --owner eic --repo containers --artifact-name rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root
# capybara capy rev 3efd159b102646ac932a4f365fc7e27e6839af01 --owner eic --repo containers --artifact-name rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root
# du -hs 2026-04-26T12-49-43+00-00_3efd159b102646ac932a4f365fc7e27e6839af01/rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root 2026-04-28T00-48-39+00-00_a65a4e733a72f81d3ab884da981648740cdeb26a/rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root
154M	2026-04-26T12-49-43+00-00_3efd159b102646ac932a4f365fc7e27e6839af01/rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root
276M	2026-04-28T00-48-39+00-00_a65a4e733a72f81d3ab884da981648740cdeb26a/rec_dis_18x275_minQ2=1000_epic_craterlake.edm4eic.root

Looks like an almost 2x file size increase. I'm not sure we can afford this. I wonder if we can define a more optimal tracking volume?

@veprbl veprbl disabled auto-merge April 28, 2026 14:58
@DraTeots
Copy link
Copy Markdown

DraTeots commented May 1, 2026

So it is basically the size of MCParticles that describe all shose tiny shower details.
I didn't see this on our files, but ours are very simple e+K+lambda compared to something like NC/CC DIS.

There is another dimension to optimize. MCParticle is saved if it was born in tracking volume and its energy is 1MeV or more. Can we also tweak this 1MeV? And especially for different part of volumes?

@veprbl veprbl mentioned this pull request May 6, 2026
11 tasks
@wdconinc
Copy link
Copy Markdown
Contributor

wdconinc commented May 7, 2026

What is the path towards progress here? Should we yank npsim 1.5? Should we yank the epic TV extension? We are now in the unfortunate condition that the head of the default branches in those repositories are conspiring to be factor 2 inefficient. And the only place where that's documented is here in a third repository.

@veprbl
Copy link
Copy Markdown
Member Author

veprbl commented May 7, 2026

npsim 1.5.x is not bad or broken, just not suitable for large scale productions. We meet 3PM ET to discuss possible ways to optimize this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants