Port tiger to rust#794
Draft
oflatt wants to merge 28 commits into
Draft
Conversation
This reverts commit 9177fbe.
… + graph gating) Ports the gurobi-optional work onto the Rust tiger port: - tiger-rs (config/main/time_ilp): in --time-ilp, run Gurobi only when the selected solver is gurobi; with --ilp-solver cbc skip it (CBC always timed), source the encoding-var count from CBC, and emit ilp_ran so the consumer can tell a skipped Gurobi run from a real one. Fixes the ILP-comparison abort on machines without gurobi_cl. - dag_in_context/lib.rs: parse ilp_ran; do not panic on a missing Gurobi duration when Gurobi was skipped. - dag_in_context/build.rs: don't let `cargo clippy` leak its wrapper into the nested tiger-rs build (fixes the `nits` failure). - infra: gurobi auto-detection, --use-gurobi/--no-gurobi flags, and per-data graph gating so tiger/CBC/statewalk/normalized graphs render without Gurobi. - setup_gurobi.sh + README/Makefile/requirements/install docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Brings the three follow-up fixes from oflatt-gurobi-optional onto the Rust port:
- normalized chart guards against ILP treatments with no cycles (has_run_cycles)
- make_macros filters benchmarks whose ILP comparison produced no timings
- configurable per-region ILP timeout: eggcc --ilp-timeout-seconds -> tiger-rs
(which already honored g_config.ilp_timeout_seconds); NightlyConfig uses 30s
for the default nightly and 5min for paper, and graphs report the actual
timeout ('30 s' vs '5 min').
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.