Skip to content

fix: avoid literally writing import.meta.url #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uhyo wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: avoid literally writing import.meta.url #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8114f6e
empty commit
uhyo Nov 3, 2023
8880595
fix import.meta.url transformed by ourselves when testing
uhyo Nov 3, 2023
5ba6c54
fix comment
uhyo Nov 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,9 @@ export function register(esbuildOptions: RegisterOptions = {}) {

const compile: COMPILE = function compile(code, filename, format) {
const define = {
'import.meta.url': IMPORT_META_URL_VARIABLE_NAME,
// Computed property name is used because literally writing
// `import.meta.url` may be transformed during our build process
['IMPORT.META.URL'.toLowerCase()]: IMPORT_META_URL_VARIABLE_NAME,
...overrides.define,
}
const banner = `const ${IMPORT_META_URL_VARIABLE_NAME} = require('url').pathToFileURL(__filename).href;${
Expand Down