Add query parameter for panel widths#112
Open
landeqiming666 wants to merge 1 commit into
Open
Conversation
|
@landeqiming666 is attempting to deploy a commit to the EGOIST's projects Team on Vercel. A member of the Team first needs to authorize it. |
Author
|
Hi maintainers, gentle follow-up on this PR. The PR remains mergeable. The only red status I can see is the Vercel preview requiring authorization from the EGOIST team; Socket checks are green, and the local validation listed in the PR description passed before submission. Could a maintainer review this when you have a chance, or authorize/re-run the Vercel preview if you want that check before review? I am happy to adjust the implementation if you prefer a different query parameter shape. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63.
This adds a small
widthsquery parameter for embedded CodePan pages. It works with the existingshowquery parameter, so an embed can choose visible panes and their relative widths without changing the editor UI:The implementation keeps the old equal-width behavior when
widthsis omitted, invalid, or does not match the visible pane count. I kept this intentionally narrower than the older PRs for this issue: no dependency updates, no layout rewrite, and no generated build output.Verification:
npm run test:pan-widthsgit diff --checknpx -y -p node@18 -c 'NODE_OPTIONS=--openssl-legacy-provider npm run build'Notes:
npm testcurrently reaches the repository's existing XO baseline failures on this checkout (import order / import extension rules in files that this PR mostly does not touch). On Node 25 it also fails earlier because the old ESLint stack depends on APIs removed from modern Node. The focused width parser test and production build both pass as listed above.IssueHunt Summary
Referenced issues
This pull request has been submitted to: