Skip to content

Messages#5

Closed
mikeyoung3k wants to merge 3 commits into
mainfrom
messages
Closed

Messages#5
mikeyoung3k wants to merge 3 commits into
mainfrom
messages

Conversation

@mikeyoung3k

@mikeyoung3k mikeyoung3k commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Merge IncomingMessage and OutgoingMessage into one Message struct.

This opens up the possibility of changing the NetService trait to just take a Message type instead of Payload and target.

TCP tests not currently running/working - a few other issues to fix before it can be readded.

I've not updated any call sites outside the net crate that use Incoming/OutgoingMessage yet - it looks like they all also require other work from architectural changes

@efimio16

efimio16 commented May 8, 2026

Copy link
Copy Markdown
Owner

Thank you for the PR, here are a few things you could improve, and some plans changed a little bit:

  1. Remove core/* from .gitignore
    Earlier in the project, before switching to the cargo workspace there was a folder core/, but now we don't need it. So just delete it from yourself

  2. Let's delete Message
    Yes I know I said before that this there will be Frame - Packet - WireMessage - Message - Payload, but when I was planning next steps I realized that it would be better to replace it with Frame - Packet - WirePayload - Payload - PayloadBody because in this way we use only the "payload" word and it won't conflict with the Message from future crates

In general, thank you for supporting the project!

@mikeyoung3k

Copy link
Copy Markdown
Collaborator Author

Righto - will have another crack

@efimio16 efimio16 deleted the messages branch July 8, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants