Messages#5
Closed
mikeyoung3k wants to merge 3 commits into
Closed
Conversation
Owner
|
Thank you for the PR, here are a few things you could improve, and some plans changed a little bit:
In general, thank you for supporting the project! |
Collaborator
Author
|
Righto - will have another crack |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge
IncomingMessageandOutgoingMessageinto oneMessagestruct.This opens up the possibility of changing the
NetServicetrait to just take aMessagetype instead ofPayloadandtarget.TCP tests not currently running/working - a few other issues to fix before it can be readded.
I've not updated any call sites outside the
netcrate that useIncoming/OutgoingMessageyet - it looks like they all also require other work from architectural changes