Skip to content

added onRequestedReview callback#8

Open
mopi1402 wants to merge 6 commits into
eeoom:mainfrom
mopi1402:main
Open

added onRequestedReview callback#8
mopi1402 wants to merge 6 commits into
eeoom:mainfrom
mopi1402:main

Conversation

@mopi1402

@mopi1402 mopi1402 commented Jan 7, 2023

Copy link
Copy Markdown

Added a callback when requestReview is trigged !

I'm using it for Google Analytics for example, like here :

serviceLocator<AdvancedInAppReview>()
        .setMinDaysBeforeRemind(7)
        .setMinDaysAfterInstall(2)
        .setMinLaunchTimes(5)
        .monitor(
          onRequestedReview: () =>
              serviceLocator<FirebaseAnalytics>().logEvent(name: 'app_review'),
        );

@eeoom

eeoom commented Jan 10, 2023

Copy link
Copy Markdown
Owner

There is no way to determine if the system really shows the rating view. The corresponding API only allows to inform the system, that it may show it. It's up to the system if its shown. According to some parameters, it will not show anything even the request is triggered. So I wonder if such a callback makes sense ...

@mopi1402

Copy link
Copy Markdown
Author

Yes, in fact, and just want to check that the requestReview was called.
I don't want to know if the dialog appears, that as you mentionned, it's not possible.

May be it's useless, and I will remove it when I will see some events on Firebase :)

@mopi1402

mopi1402 commented Jan 14, 2023

Copy link
Copy Markdown
Author

Ok, so now I'm seeing event on Firebase Analytics :
image

As you notice, it's not possible to know if someone made a review from this dialog (and if the dialog has opened), but I'm sure I integrated you lib correctly and it's working on production ;)

Thank you for you work !

@StarProxima

Copy link
Copy Markdown

@eeoom Can you consider this pr again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants