added onRequestedReview callback#8
Open
mopi1402 wants to merge 6 commits into
Open
Conversation
update min SDK and compile SDK version
Owner
|
There is no way to determine if the system really shows the rating view. The corresponding API only allows to inform the system, that it may show it. It's up to the system if its shown. According to some parameters, it will not show anything even the request is triggered. So I wonder if such a callback makes sense ... |
Author
|
Yes, in fact, and just want to check that the requestReview was called. May be it's useless, and I will remove it when I will see some events on Firebase :) |
Author
|
@eeoom Can you consider this pr again? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Added a callback when requestReview is trigged !
I'm using it for Google Analytics for example, like here :