Feature/adr database library#13
Merged
Merged
Conversation
This allows the connection to be re-established if e.g. the database is restarted. - Migrate from psycopg2-binary to psycopg[binary] and psycopg-pool - Replace direct psycopg2 connections with ConnectionPool in PostgreSQL adapters - Update Dockerfile comment to reflect psycopg3 usage - Initialize connection pool with min_size=1 and max_size=10
ThomasKalverda
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ThomasKalverda Zoals afgesproken een "FYI" PR op ec-issuer.
Deze is vooral een ADR waarin ik de keuze voor de postgres lib beschrijf.
De bijbehorende changes in code zijn slechts slightly related. Het ADR beschrijft dat we uberhaupt psycopg gebruiken; terwijl we dat dus eigelijk al deden - maar dat niet gedocumenteerd was.
d10d6ce is dus meer slechts om aan te geven hoe het eindresultaat van een implementatie volgens deze ADR er uit zou kunnen zien.