Fix push signature verification: include question in the signed string#116
Open
sysrow wants to merge 1 commit into
Open
Fix push signature verification: include question in the signed string#116sysrow wants to merge 1 commit into
sysrow wants to merge 1 commit into
Conversation
The eduMFA server signs the push challenge as
{nonce}|{url}|{serial}|{question}|{title}|{sslverify} (6 fields). Upstream
commit 031858d ("Remove question from push request payload and replace it
with a static localizable question") dropped question from the payload and,
with it, from the signed-string reconstruction. The app now rebuilds only
5 fields, so the RSA signature of every incoming challenge fails to verify,
the request is rejected before the dialog is shown, and push approval is
impossible against a stock eduMFA server.
Re-add question to PushRequest (model, JSON, identifier) and insert it into
the signed string in the position the server uses. The on-screen text stays
the static localized question introduced by 031858d; question is used only
to reconstruct the signed payload, not for display.
Member
|
I didn't encounter this problem yet within my eduMFA testing setup yet. Could this be related to question being customized or not? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eduMFA server signs the push challenge as
{nonce}|{url}|{serial}|{question}|{title}|{sslverify} (6 fields). Upstream
commit 031858d ("Remove question from push request payload and replace it
with a static localizable question") dropped question from the payload and,
with it, from the signed-string reconstruction. The app now rebuilds only
5 fields, so the RSA signature of every incoming challenge fails to verify,
the request is rejected before the dialog is shown, and push approval is
impossible against a stock eduMFA server.
Re-add question to PushRequest (model, JSON, identifier) and insert it into
the signed string in the position the server uses. The on-screen text stays
the static localized question introduced by 031858d; question is used only
to reconstruct the signed payload, not for display.