Skip to content

⚡ Optimize public holdout validation comparison recalculation #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edithatogo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡ Optimize public holdout validation comparison recalculation #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions public/diff.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
diff --git a/models/primarycare_model/calibration/public_holdout_validation.py b/models/primarycare_model/calibration/public_holdout_validation.py
index bc09e8a..7cea9bb 100644
--- a/models/primarycare_model/calibration/public_holdout_validation.py
+++ b/models/primarycare_model/calibration/public_holdout_validation.py
@@ -316,9 +316,9 @@ def _ascii_safe(value: str) -> str:
return normalized.encode("ascii", errors="ignore").decode("ascii")


-def holdout_gate_blockers(gate_id: str) -> tuple[str, ...]:
+def holdout_gate_blockers(gate_id: str, comparisons: tuple[PublicHoldoutComparison, ...] | None = None) -> tuple[str, ...]:
blockers = []
- for comparison in build_public_holdout_comparisons():
+ for comparison in (comparisons if comparisons is not None else build_public_holdout_comparisons()):
if comparison.gate_id != gate_id or comparison.status == "passed":
continue
failed_groups = ", ".join(_ascii_safe(group) for group in comparison.failing_groups[:5])
@@ -362,7 +362,7 @@ def main(argv: list[str] | None = None) -> int:
)

if args.require_pass and any(comparison.status != "passed" for comparison in comparisons):
- print("\n".join(holdout_gate_blockers("CAL-G-003") + holdout_gate_blockers("CAL-G-004")), file=sys.stderr)
+ print("\n".join(holdout_gate_blockers("CAL-G-003", comparisons=comparisons) + holdout_gate_blockers("CAL-G-004", comparisons=comparisons)), file=sys.stderr)
return 1
return 0
Loading