🧪 Add Error Test for Dash Browser Smoke Check Timeout - #143
Conversation
🎯 **What:** The `check_dash_browser_smoke.py` script waits for a spawned dash server with a timeout, and handles `subprocess.TimeoutExpired` by killing the process. The missing testing gap for this `TimeoutExpired` exception block has been addressed. The actual bug where we forgot to call `process.wait()` after `process.kill()` inside `scripts/check_dash_browser_smoke.py` was also fixed to properly avoid zombie processes. 📊 **Coverage:** - Covered the `subprocess.TimeoutExpired` catch block during the initial timeout for closing the spawned dash server process. - Ensured `kill()` is correctly called. - Ensured `wait()` is correctly called right after `kill()`. ✨ **Result:** The improvement in test coverage prevents future regressions and potential un-waited zombie processes when timeouts trigger.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
1 participant
🎯 What:
The
check_dash_browser_smoke.pyscript waits for a spawned dash server with a timeout, and handlessubprocess.TimeoutExpiredby killing the process.The missing testing gap for this
TimeoutExpiredexception block has been addressed. The actual bug where we forgot to callprocess.wait()afterprocess.kill()insidescripts/check_dash_browser_smoke.pywas also fixed to properly avoid zombie processes.📊 Coverage:
subprocess.TimeoutExpiredcatch block during the initial timeout for closing the spawned dash server process.kill()is correctly called.wait()is correctly called right afterkill().✨ Result:
The improvement in test coverage prevents future regressions and potential un-waited zombie processes when timeouts trigger.
PR created automatically by Jules for task 7121562180590748568 started by @edithatogo