Skip to content

fix(#0089): fall back to generic value when custom translation is null#90

Merged
SigifredoChaconB merged 13 commits into
7369-admin-angular-upgradefrom
fix/generic-translations-bug-089
May 28, 2026
Merged

fix(#0089): fall back to generic value when custom translation is null#90
SigifredoChaconB merged 13 commits into
7369-admin-angular-upgradefrom
fix/generic-translations-bug-089

Conversation

@SigifredoChaconB

Copy link
Copy Markdown

Description

Fixes translation values loading in the edit translation modal so that keys with null values
in custom fall back to the generic value.

Changes include:

  • Updated translationValues loading in DisplayTranslationsEditComponent to use custom[key] || generic[key]
    instead of spread operator, matching the behavior of the original app
  • This fixes the case where translation keys saved with null in custom by the original AngularJS admin
    tool caused all language fields to appear empty when opening the edit modal in the new admin tool
  • Added unit test to cover the null custom value fallback to generic
Screenshot 2026-05-27 at 4 26 02 PM

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

SigifredoChaconB and others added 13 commits May 5, 2026 15:33
* changes based on feedback, show errors and extract base-modal.less

* change made based on reviewer feedback
…ove setTimeout (#61)

* changes based on feedback, show errors and extract base-modal.less

* subscription to the changes service and timeouts were eliminated

* change made based on reviewer feedback
@SigifredoChaconB SigifredoChaconB merged commit 4e412d3 into 7369-admin-angular-upgrade May 28, 2026
101 of 107 checks passed
hectorguillen-blip added a commit that referenced this pull request Jun 3, 2026
…ntact search (#91)

* fix(#13): fix Select2 contact search using PouchDB views and add freetext design doc

* fix(#13): fix Select2 contact search using PouchDB views and add freetext design doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants