fix(#0089): fall back to generic value when custom translation is null#90
Merged
SigifredoChaconB merged 13 commits intoMay 28, 2026
Merged
Conversation
…ove setTimeout (#61) * changes based on feedback, show errors and extract base-modal.less * subscription to the changes service and timeouts were eliminated * change made based on reviewer feedback
…sername interface (#63)
…/medic-cht-core into 7369-admin-angular-upgrade
…/medic-cht-core into 7369-admin-angular-upgrade
…/medic-cht-core into 7369-admin-angular-upgrade
…/medic-cht-core into 7369-admin-angular-upgrade
…/medic-cht-core into 7369-admin-angular-upgrade
…/medic-cht-core into 7369-admin-angular-upgrade
jomcarvajal
approved these changes
May 27, 2026
4e412d3
into
7369-admin-angular-upgrade
101 of 107 checks passed
hectorguillen-blip
added a commit
that referenced
this pull request
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes translation values loading in the edit translation modal so that keys with null values
in custom fall back to the generic value.
Changes include:
instead of spread operator, matching the behavior of the original app
tool caused all language fields to appear empty when opening the edit modal in the new admin tool
Code review checklist
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.