Skip to content

fix(#0086): replace date time dropdowns with select elements#87

Merged
SigifredoChaconB merged 12 commits into
7369-admin-angular-upgradefrom
improvement/dropdown-to-select-date-time-086
May 26, 2026
Merged

fix(#0086): replace date time dropdowns with select elements#87
SigifredoChaconB merged 12 commits into
7369-admin-angular-upgradefrom
improvement/dropdown-to-select-date-time-086

Conversation

@SigifredoChaconB

Copy link
Copy Markdown

Description

Replaces the custom Bootstrap dropdown components in the Display Date & Time module with native select elements to maintain consistency with the rest of the admin tool UI.

Changes include:

  • Replaced custom Bootstrap dropdown for date format selection with a native select element bound to dateFormatSelection via ngModel
  • Replaced custom Bootstrap dropdown for datetime format selection with a native select element bound to dateTimeFormatSelection via ngModel
  • Removed unused dropdown LESS styles and replaced with width selectors for the native select elements
  • Removed date parameter from onDateFormatSelected and onDateTimeFormatSelected since ngModel handles the value update directly
  • Updated unit tests to reflect the new select elements and simplified method signatures
Screenshot 2026-05-25 at 3 17 21 PM Screenshot 2026-05-25 at 3 26 17 PM Screenshot 2026-05-25 at 3 26 42 PM Screenshot 2026-05-25 at 3 26 46 PM

Code review checklist

  • Readable: Concise, well named, follows the style guide, documented if necessary.
  • Tested: Unit and/or e2e where appropriate
  • Internationalised: All user facing text

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

SigifredoChaconB and others added 12 commits May 5, 2026 15:33
* changes based on feedback, show errors and extract base-modal.less

* change made based on reviewer feedback
…ove setTimeout (#61)

* changes based on feedback, show errors and extract base-modal.less

* subscription to the changes service and timeouts were eliminated

* change made based on reviewer feedback

@jomcarvajal jomcarvajal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigifredoChaconB SigifredoChaconB merged commit 8506a98 into 7369-admin-angular-upgrade May 26, 2026
158 of 170 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants