Add ThreadSanitizer CI and explicit sanitizer control#40
Open
edge90 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 99.81% 99.74% -0.07%
==========================================
Files 18 18
Lines 2129 1992 -137
Branches 244 281 +37
==========================================
- Hits 2125 1987 -138
Misses 4 4
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Add TSan build (Clang only, Debug, maintainer mode) - Add explicit enable_coverage, enable_asan, enable_ubsan, enable_tsan flags - Add validation step to catch TSan + ASan/UBSan conflicts - Add "test CMake defaults" build (packaging_maintainer_mode=OFF) - Standardize ON/OFF casing for CMake boolean flags - Skip explicit sanitizer flags when packaging_maintainer_mode=OFF (use CMake defaults) - Coverage always respects enable_coverage flag (independent of maintainer_mode) Closes #29
edge90
force-pushed
the
ci/add-tsan-tests
branch
from
479eda6 to
03bf780
Compare
- macOS gcc-14: doesn't support ASan/UBSan (linker issues) - Windows llvm-19.1.1: ASan causes iterator debug level mismatch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enable_coverage,enable_asan,enable_ubsan,enable_tsanmatrix flagspackaging_maintainer_mode=OFF) to verify developer defaults workpackaging_maintainer_mode=OFF(use CMake defaults)enable_coverageflag (independent of maintainer_mode)Test plan
Closes #29