💚 Rework Moodle Plugin CI and fix pgsql + ESLint failures - #8
Merged
Conversation
DamienVauchel
requested review from
johnny1991,
sserot and
traezh
as code owners
June 29, 2026 13:45
traezh
approved these changes
Jun 29, 2026
Order outdated-content query by the selected column so SELECT DISTINCT is valid on PostgreSQL; suppress no-alert/consistent-return/camelcase warnings that broke the grunt step under --max-lint-warnings 0.
DamienVauchel
changed the title
Inline eslint-disable comments shifted the AMD source content, leaving the committed amd/build source maps stale (grunt rebuilds them and fails). A plugin-level .eslintrc keeps amd/src byte-identical so the build stays in sync, while still silencing no-alert/consistent-return/camelcase under grunt --max-lint-warnings 0.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Purpose
Rework the Moodle Plugin CI workflow and fix the two failures it surfaced so the pipeline is green.
📝 Summary of Changes
.github/workflows/ci.yml— run on all push/PR, add the full moodle-plugin-ci step set (phplint, phpmd, phpcs, phpdoc, validate, savepoints, mustache, grunt, phpunit, behat), test PHP 8.1/8.2/8.3 onMOODLE_405_STABLEagainst both PostgreSQL and MariaDB.classes/local/activity_manager.php— order the outdated-content query by the selected column (es.edflexid) soSELECT DISTINCTis valid on PostgreSQL (MariaDB tolerated the oldORDER BY es.lastsync, es.id, pgsql rejected it). Dropped two dead query params.amd/src/*.js— suppress theno-alert,consistent-returnandcamelcaseESLint warnings that broke the grunt step under--max-lint-warnings 0. Comment-only, so the committedamd/build/stays in sync.🧪 Testing
MOODLE_405_STABLE.activity_manager_test::test_get_outdated_edflex_contentids_in_chunksnow passes on PostgreSQL.🔄 Regression Risk
Low. The query change only affects result ordering of an internal sync chunk iterator (callers don't depend on
lastsyncorder); the JS changes are lint suppressions with no runtime effect.