Fix: Executor can fail to send error body#61
Merged
Conversation
The except branch in execute() did its cleanup (upload_remaining_artifacts, update_failure) before send_error, so any exception raised in cleanup would escape the branch with the diagnostic payload never reaching the app. The finally still sent DONE(failure), but the app was left with no /error detail. Restructure the branch to lock self.error in immediately, then run cleanup guarded with try/except so it can't derail reporting, then send_error last. update_failure stays before send_error to preserve the status-update ordering its docstring describes. While here, fix three latent bugs in upload_artifact that would have hit this same trap: a typoed self.error_obj attribute, a nonexistent self.bucket_out_path reference, and an ArtifactS3UploadError constructed with the artifact object where the name string was expected. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jalvord1
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've observed cases where a job fails, and the app is aware, but the executor fails to send an error report. Essentially any time we have an uncaught exception in the
finallyblock ofexecute, this is a risk.This change hardens the graceful shutdown process to catch potential sources of these additional exceptions, and also fixes two bugs that Claude found that could have triggered the similar failures.