Hotfix: Default to Birth Sex#157
Draft
jayckaiser wants to merge 1 commit into
Draft
Conversation
Collaborator
|
@jayckaiser is this still something you see as valuable, given the latest decisions to resolve this on podium side? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hotfix: Default to Birth Sex
Description & motivation
By default, if
studentEducationOrganizationAssociations.genderIdentityis not populated, no gender information makes it through todim_student. In some Stadium implementations (like SCDE),genderIdentityis not accessible, butbirthSexis.This PR proposes defaulting to
birthSexvalue if thegenderIdentityfield is empty.PR Merge Priority:
Changes to existing files:
bld_ef3__immutable_stu_demos.sql: Use a coalesce to prefer gender identity, then birth sex.Tests and QC done:
This code has not been run in SCDE yet. I'd like to discuss whether this should be a default or a config option.
edu_wh PR Review Checklist:
Make sure the following have been completed before approving this PR:
## New Featuresfor features, etc.