Make eckit_DIR explicit in fckit_test_downstream_* tests

[wdeconinck]

Description

Fix for issue #95 where the found eckit in fckit_test_downstream_fypp was not the one used by fckit.

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 51.07%. Comparing base (86e0bd1) to head (bfebc4c).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #103   +/-   ##
========================================
  Coverage    51.07%   51.07%           
========================================
  Files           58       58           
  Lines         4854     4854           
  Branches       453      453           
========================================
  Hits          2479     2479           
  Misses        2375     2375           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[DJDavies2]

This change works for me. However can you also add the same change to src/tests/test_downstream_fctest/test-downstream.sh.in as well please? I don't think I can push the change to this branch but it is just a copy and paste. fckit_test_downstream_fctest is failing the same way and can be fixed the same way.

[wdeconinck]

This change works for me. However can you also add the same change to src/tests/test_downstream_fctest/test-downstream.sh.in as well please? I don't think I can push the change to this branch but it is just a copy and paste. fckit_test_downstream_fctest is failing the same way and can be fixed the same way.

Hi @DJDavies2 good point. Done now.

[DJDavies2]

Thanks, all tests work now.