Skip to content

Cdm obs edits may 2026 issues 25 26 - #27

Merged
garciampred merged 4 commits into
mainfrom
cdm-obs_edits_may_2026_issues_25_26
Jun 4, 2026
Merged

Cdm obs edits may 2026 issues 25 26#27
garciampred merged 4 commits into
mainfrom
cdm-obs_edits_may_2026_issues_25_26

Conversation

@sjnoone

@sjnoone sjnoone commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Hi Ed,
The units table has been edited to include 1016 dimensionless/unitless NULL NULL as per issue #26 . In addition, the agreed changes proposed by Kalev reference issue #25 have also been implemented on this branch.

After 48 hours can you please merge these changes into the main CMD OBS repository.

best
Simon

@sjnoone
sjnoone requested a review from EddyCMWF June 1, 2026 17:54
@sjnoone

sjnoone commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

I have made some new minor edits to observed_variable.csv infilled missing fields for variable 111 fields: parameter_group domain sub_domain with humidity | atmospheric | upper air.

@garciampred

garciampred commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

I have fixed non-ascii characters that made the CI fail. But it is still failing because of variables 139 and 140 (upper air wind speeds) were removed, and the CUON test uses them. I don't recall if removing these was decided at the end, was it? I don't see it in the issues.

@sjnoone

sjnoone commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

I have fixed non-ascii characters that made the CI fail. But it is still failing because of variables 139 and 140 (upper air wind speeds) were removed, and the CUON test uses them. I don't recall if removing these was decided at the end, was it? I don't see it in the issues.

see issue #18,19 and subsequent pull request #24 all agreed on CDM-OBS Governance call in April 2026. Redundancy Cleanup: IDs 139 and 140 are duplicates of IDs 104 and 105. Removing them prevents mapping errors and simplifies the table.

@garciampred

Copy link
Copy Markdown
Collaborator

It is green now ; ) I mapped those variables in the CUON reader so the tests passes now.

@garciampred
garciampred merged commit c9c4aaa into main Jun 4, 2026
3 of 4 checks passed
@garciampred
garciampred deleted the cdm-obs_edits_may_2026_issues_25_26 branch June 4, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants