Enable dual precision flang builds - #157
Merged
Merged
Conversation
…mbol in the" This reverts commit f6b3fc7.
…s#114) PR ecmwf-ifs#114 ("Remove unused symbols and imports from FIELD_DEFAULTS_MODULE") introduced per-precision field_api_defaults_${prec} object libraries by splitting field_defaults_module.F90 out of field_api_core (commit be2bda3, "Compile field_defaults_module for each precision"). This reverts that change, folding field_defaults_module.F90 back into field_api_core and restoring its GET_VIEW_ABORT/DELAYED compile definitions and the PREC parameter on field_api_add_object_library. It also reverts the dependent LLVMFlang workaround from PR ecmwf-ifs#137 (commit f07db36) that linked field_api_defaults_${DEFAULT_PRECISION} into the buffer/factory/shuffle object libraries, since those targets no longer exist. The unrelated copyright-header commit (333cf7c) and the later FIELD_API_COMPILE_DEFINITIONS / hipfort additions are preserved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dareg
approved these changes
Jul 29, 2026
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the field_api object libraries truly precision independent, thereby enabling dual precision builds for flang, as described in #138.