Skip Unicode escape for characters supported by the file's charset#1518
Merged
ptziegler merged 1 commit intoMay 19, 2026
Merged
Conversation
StringConverter forced a Unicode escape (\uXXXX form) for every non-ASCII character whenever the source file was not UTF-8 / UTF-16. For sources saved in windows-1252, ISO-8859-1, etc. this meant German umlauts became e.g. \u00DC even though the file charset can represent them natively, harming readability. Generalize the existing UTF-8 / UTF-16 fast-path to a charset-aware one: ask the file's charset whether each character can be encoded, only escape what it cannot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StringConverter forced a Unicode escape (\uXXXX form) for every non-ASCII character whenever the source file was not UTF-8 / UTF-16. For sources saved in windows-1252, ISO-8859-1, etc. this meant German umlauts became e.g. \u00DC even though the file charset can represent them natively, harming readability.
Generalize the existing UTF-8 / UTF-16 fast-path to a charset-aware one: ask the file's charset whether each character can be encoded, only escape what it cannot.