Fix #295#325
Conversation
|
can you remove those extra commits for NPE so we can review only the new feature and then we will examine the commits that fix potential NPE |
done |
|
|
||
| /**MyEnumWithCustomConstructor doc*/ | ||
| @VertxGen | ||
| public enum MyEnumWithCustomConstructor { |
There was a problem hiding this comment.
it should be renamed with XXXWithCustomFactory because constructor has a very specific meaning
There was a problem hiding this comment.
ok, I did the required changes... :D
But it is really called an enum constructor, not a factory :)
Look here: https://docs.oracle.com/javase/tutorial/java/javaOO/enum.html
| import io.vertx.core.json.JsonObject; | ||
|
|
||
| @DataObject(generateConverter = true, publicConverter = true) | ||
| public class DataObjectWithEnumWithMapper { |
|
A couple comments have been made to rename things more consistently. |
Signed-off-by: Cristiano V. Gavião <cvgaviao@gmail.com>
|
I think we need also then to update the |
|
@cvgaviao can you update the index.adoc and readme files with the changes brought the to model ? |
|
How can we help to get this feature ? |
|
this PR is missing update to documentation as said in my last comment, if you can contribute it it is fine |
|
Update files here Fyro-Ing@1939916 if @cvgaviao can't merge in few days, i'll do a PR directly Note : Readme updated to conform with json-mappers.properties, not |
|
thanks!
…On Mon, Sep 13, 2021 at 6:39 PM Fyro ***@***.***> wrote:
Update files here ***@***.***
<Fyro-Ing@1939916>
if @cvgaviao <https://github.com/cvgaviao> can't merge in few days, i'll
do a PR directly
Note : Readme updated to conform with json-mappers.properties, not @Mapper
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABXDCTI3FHAOGPF5P7KBSTUBYSMRANCNFSM4ZJFYOSQ>
.
|
|
@Fyro-Ing, you can do that. ;)
|
|
new PR #341 |
|
merged with new PR. |
3 participants
Signed-off-by: Cristiano V. Gavião cvgaviao@gmail.com
Motivation:
Allows the developer to have enum in their data classes that need to convert from and to JSON.
#295