Skip to content

wotpy: Change strict check rules#38

Open
egekorkan wants to merge 2 commits into
eclipse-thingweb:mainfrom
egekorkan:patch-11
Open

wotpy: Change strict check rules#38
egekorkan wants to merge 2 commits into
eclipse-thingweb:mainfrom
egekorkan:patch-11

Conversation

@egekorkan

Copy link
Copy Markdown
Member

This should solve eclipse-thingweb/wot-py#34. @agmangas @Nickgraviton please have a look

Signed-off-by: Ege Korkan <egekorkan@gmail.com>
@egekorkan egekorkan requested a review from a team as a code owner June 24, 2026 08:23
@eclipse-otterdog

Copy link
Copy Markdown

Thank you for raising a pull request to update the configuration of your GitHub organization.
You can manually add reviewers to this PR to eventually enable auto-merging.

The following conditions need to be fulfilled for auto-merging to be available:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource
Otterdog commands and options

You can trigger otterdog actions by commenting on this PR:

  • /otterdog team-info checks the team / org membership for the PR author
  • /otterdog validate validates the configuration change
  • /otterdog validate info validates the configuration change, printing also validation infos
  • /otterdog check-sync checks if the base ref is in sync with live settings
  • /otterdog merge merges and applies the changes if the PR is eligible for auto-merging (only accessible for the author)
  • /otterdog done notifies the self-service bot that a required manual apply operation has been performed (only accessible for members of the admin team)
  • /otterdog apply re-apply a previously failed attempt (only accessible for members of the admin team)

@eclipse-otterdog

Copy link
Copy Markdown

The author (egekorkan) of this PR is associated with this organization in the role of MEMBER.

Additionally, egekorkan is a member of the following teams:

@eclipse-otterdog

This comment has been minimized.

@eclipse-otterdog

Copy link
Copy Markdown

This Pull Request is eligible for auto-merging as it passed the following checks:

  • valid configuration
  • approved by a project lead
  • does not require any secrets
  • does not update settings only accessible via the GitHub Web UI
  • does not remove any resource

Tip

In order to automatically merge and apply the changes, add a comment /otterdog merge. 🚀

@egekorkan

Copy link
Copy Markdown
Member Author

@Nickgraviton

Copy link
Copy Markdown

@egekorkan I would suggest removing specific versions of Python in the status checks since these are bound to change periodically. I already plan to add Python 3.13 and 3.14 tests for example.
Perhaps it would be best to:

  • either remove specific status checks that prevent merging (we can always manually check if the tests succeeded before merging)
  • or to add a catch-all aggregate test like "tests-passed" in the Github actions that depends on the existing "test" stage with the Python version matrix and add that as the status check

Removed webhook for Travis CI and status checks for multiple Python versions.

Signed-off-by: Ege Korkan <egekorkan@gmail.com>
@eclipse-otterdog

Copy link
Copy Markdown

Please find below the validation of the requested configuration changes:

Diff for fc8dd21
Project iot.thingweb[github_id=eclipse-thingweb]
  there have been 1 validation infos, enable verbose output to display them.

  
!   repository[name="wot-py"] {
!     description = "wotpy is an experimental asynchronous implementation of a W3C Web of Things runtime" -> "A 
WoT runtime in Python for Thing and Consumer applications"
!     homepage    = "" -> "https://thingweb.io"
!   }

-  remove repo_webhook[url="https://notify.travis-ci.org", repository=wot-py] {
-    active       = true
-    content_type = "form"
-    events       = [
-      "create"
-      "delete"
-      "issue_comment"
-      "member"
-      "public"
-      "pull_request"
-      "push"
-      "repository"
-    ],
-    insecure_ssl = "0"
-    secret       = null
-  }

  
!   branch_protection_rule[pattern="develop", repository=wot-py] {
!     required_status_checks        = [
-      "call-python-310-testing / python-testing"
-      "call-python-37-testing / python-testing"
-      "call-python-38-testing / python-testing"
-      "call-python-39-testing / python-testing"
!     ]
!     requires_strict_status_checks = true -> false
!   }
  
  Plan: 0 to add, 4 to change, 1 to delete.

@egekorkan

Copy link
Copy Markdown
Member Author

/otterdog merge

@eclipse-otterdog

Copy link
Copy Markdown

Warning

This pull request cannot be auto-merged via /otterdog merge

  • pull request cannot be automatically merged (contains secrets, requires web UI changes, includes deletions or touches non-configuration files)

@egekorkan

Copy link
Copy Markdown
Member Author

@eclipse-thingweb/eclipsefdn-security or @heurtematte could you look into this PR to merge it? Then I will delete the other repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants