Remove dead NLS message constants and an orphaned key - #2416
Open
vogella wants to merge 1 commit into
Open
Conversation
Messages.SpyProcessor_category and Messages.ModelImportPage1_Import1 are declared but have no entry in their messages.properties and are read nowhere, so NLS.initializeMessages logs a "NLS missing message" warning for each of them on class initialization. The key XmiTab_TypeTextToSearch in the tabs messages.properties has no matching field in the sibling Messages class. XmiTab imports org.eclipse.e4.tools.emf.ui.internal.Messages instead and reads the value through its injected instance field, so the entry is never loaded.
vogella
marked this pull request as ready for review
August 10, 2026 05:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three NLS resources are dead.
Messages.SpyProcessor_categoryinorg.eclipse.pde.spy.coreandMessages.ModelImportPage1_Import1inorg.eclipse.e4.tools.emf.uiare declared but have no entry in theirmessages.propertiesand are read nowhere, soNLS.initializeMessagescurrently logs a "NLS missing message" warning for each on class initialization. Removing them silences that noise.The third is the reverse case: the key
XmiTab_TypeTextToSearchininternal/common/component/tabs/messages.propertieshas no matching field in the siblingMessagesclass.XmiTabimportsorg.eclipse.e4.tools.emf.ui.internal.Messagesinstead and reads the value through its injected instance field, so that entry is never loaded and the visible text is unaffected.Note that only the two field removals are compile-verified; the orphaned key is bound reflectively, so it was checked by reading the code. Built locally with
mvn verify -pl :org.eclipse.pde.spy.core,:org.eclipse.e4.tools.emf.ui.