Remove FeatureExportJob and PluginExportJob compatibility stubs - #2413
Open
vogella wants to merge 1 commit into
Open
Remove FeatureExportJob and PluginExportJob compatibility stubs#2413vogella wants to merge 1 commit into
vogella wants to merge 1 commit into
Conversation
Both classes were added in 2010 as internal compatibility shims for bug 301178. They sit in org.eclipse.pde.internal.ui.build, which is exported with x-internal:=true, and each only forwards its constructor to FeatureExportOperation resp. PluginExportOperation without adding behaviour. Nothing in the repository references them anymore; the export wizards instantiate the operations directly. The PDEUIMessages keys FeatureExportJob_name and PluginExportJob_name stay, since the export wizards still pass them to the operations.
vogella
force-pushed
the
remove-export-job-compat-stubs
branch
from
August 10, 2026 05:58
c3f217e to
e84de1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FeatureExportJob and PluginExportJob were added in 2010 as internal compatibility shims for bug 301178. Sixteen years later nothing in the repository references them anymore, and they live in
org.eclipse.pde.internal.ui.build, which is exported withx-internal:=true, so no legitimate consumer can depend on them either.Each class does nothing beyond forwarding its constructor to
FeatureExportOperationresp.PluginExportOperation. The export wizards already instantiate those operations directly, and thePDEUIMessageskeys stay because the wizards still pass them along.This drops 58 lines of dead code. Verified with
mvn verify -pl :org.eclipse.pde.ui -Papi-check -Dcompare-version-with-baselines.skip=false, which reports 0 API errors.