Make grant loader localKey domain prefix configurable#177
Merged
Conversation
|
markpatton
approved these changes
Apr 20, 2026
Contributor
markpatton
left a comment
markpatton
left a comment
There was a problem hiding this comment.
Looks good. I did some grepping through the rest of pass-support for other hard coded JHU constants and could not find any others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the domain prefix configurable which is used in the localKey in the Grant Loader model. This is needed if another institution wants to use the Grant Loader default update logic (
jhuprofile).