-
Notifications
You must be signed in to change notification settings - Fork 5
Doip server initial code #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
VinaykumarRS1995
wants to merge
17
commits into
eclipse-opensovd:main
Choose a base branch
from
VinaykumarRS1995:doip-server-initial
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
04327e2
feat(doip): implement header parsing with tokio codec
VinaykumarRS1995 a9bd564
test(doip): add unit tests for header_parser
VinaykumarRS1995 49e0f7e
feat(error): add DoIP error types and NRC codes
VinaykumarRS1995 2208cbb
feat(uds): add UdsHandler trait for pluggable backends
VinaykumarRS1995 1d5e99a
refactor(doip): address PR review comments and Improvement
VinaykumarRS1995 b12490a
style: apply cargo fmt
VinaykumarRS1995 7aefa63
refactor(doip): address PR review comments
VinaykumarRS1995 6c0d47f
refactor: fix PR review
VinaykumarRS1995 ceb170d
chore: move doip-server into Cargo workspace to resolve merge conflict
VinaykumarRS1995 b98ff03
fix(review): address review comments
VinaykumarRS1995 dfe3c85
fix(review): address .toml config, empty data validation.
VinaykumarRS1995 6d8eab2
fix(review): add unit tests, trace logging
VinaykumarRS1995 eff3242
fix(review): revert CI SHAs, use constants in vehicle_id, fix doc and…
VinaykumarRS1995 1eb7c2b
fix(review): address review comments
VinaykumarRS1995 5cd28b3
fix(review): address second round of review comments
VinaykumarRS1995 e1039b4
docs: rename diagrams, refactor sequence diagram, add rendered SVGs
VinaykumarRS1995 53214b3
fix(review): address reviewer comments on doip-server-initial
VinaykumarRS1995 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the workspace Cargo.toml, so this information shouldn’t be removed. I’d suggest keeping these changes in the package-level Cargo.toml instead. I also noticed that the comments below were removed, please keep them intact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored — lint header comment and all per-lint explanatory comments are kept intact.