Skip to content

Do not offer Make Static action for default interface methods - #3853

Merged
datho7561 merged 1 commit into
eclipse-jdtls:mainfrom
SougandhS:interfaceStaticFix
Jul 23, 2026
Merged

Do not offer Make Static action for default interface methods#3853
datho7561 merged 1 commit into
eclipse-jdtls:mainfrom
SougandhS:interfaceStaticFix

Conversation

@SougandhS

@SougandhS SougandhS commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Prevent showing "Make Static" quick fix for default methods in interfaces.
Before:
now

@eclipse-ls-bot

Copy link
Copy Markdown
Contributor

Can one of the admins verify this patch?

@SougandhS

Copy link
Copy Markdown
Contributor Author

Hi @datho7561,
could you please check this PR when you get some time ?

@SougandhS
SougandhS force-pushed the interfaceStaticFix branch 2 times, most recently from dc2a5e4 to 5cd6b2d Compare July 22, 2026 07:58

@datho7561 datho7561 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks, Sougandh!

@datho7561

Copy link
Copy Markdown
Contributor

Actually, do you mind adding a test case for this?

Prevent showing "Make Static" quick fix for default methods in
interfaces.
@SougandhS
SougandhS force-pushed the interfaceStaticFix branch from 5cd6b2d to 794e3d7 Compare July 22, 2026 21:39
@SougandhS

Copy link
Copy Markdown
Contributor Author

Actually, do you mind adding a test case for this?

Added now 👍

Test failure is unrelated

@datho7561

Copy link
Copy Markdown
Contributor

Thanks, Sougandh!

@datho7561 datho7561 added this to the End of July 2026 milestone Jul 23, 2026
@datho7561
datho7561 merged commit 76efbab into eclipse-jdtls:main Jul 23, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants