Convert "unreachable catch" problem - #219
Draft
datho7561 wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
hmm no new passes and I didn't actually notice any differences when running locally. I'll double check it before merging |
datho7561
marked this pull request as draft
March 24, 2026 20:04
eg.
```java
public class UnreachableCatch {
static class ExceptionA extends Exception {
}
static class ExceptionB extends Exception {
}
public static void foo() {
try {
if (!true) {
throw new ExceptionB();
} else {
throw new ExceptionA();
}
} catch (ExceptionA e1) {
} catch (ExceptionB | ExceptionA e2) {
}
}
}
```
Signed-off-by: David Thompson <davthomp@redhat.com>
datho7561
force-pushed
the
unreachable-catch
branch
from
March 25, 2026 14:33
5f244c5 to
e41f486
Compare
second type in a group of catch statements subclasses a different one, but this is not reported by ECJ Signed-off-by: David Thompson <davthomp@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg.