Fix adding old-style javadocs when markdown comments are defaulted - #3104
Merged
Conversation
- fix JavaDocAutoIndentStrategy to keep track of when an old javadoc comment is created in indentAfterNewline() and pass this info along when creating tags including to CodeGeneration methods so that the choice of using markdown templates is not based on the use markdown preference and is overridden - add new APIs to CodeGeneration and StubUtility to take added boolean - bump up o.e.jdt.core.manipulation minor version - fixes eclipse-jdt#3100 to
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix JavaDocAutoIndentStrategy to keep track of when an old javadoc comment is created in indentAfterNewline() and pass this info along when creating tags including to CodeGeneration methods so that the choice of using markdown templates is not based on the use markdown preference and is overridden
add new APIs to CodeGeneration and StubUtility to take added boolean
bump up o.e.jdt.core.manipulation minor version
fixes Adding javadoc comment with /** when use markdown selected does not work #3100
to
What it does
See issue.
How to test
See issue.
Author checklist