Merge master into BETA_JAVA27 branch - #3094
Merged
Merged
Conversation
- It shares split packages with org.eclipse.jdt.uu. eclipse-platform/eclipse.platform.releng.aggregator#3927
The Typing preference page threw an NPE when opened with no active Java editor, since a null compilation unit was dereferenced without a check; this adds the missing null guard, consistent with the existing null-safe handling right below it. Fix: #3068
Tracings of recent SaveParticipantTest fail show the quick diff initialize job, accessing GapTextStore in parallel to the tests. This change joins this initialize job, prior to editing CUs from the tests - to avoid potential race conditions. See: #79
* Fix add missing method declaration when target is another CU - modify AddMissingMethodDeclarationFixCore to properly find the type of the ExpressionMethodReference instead of looking for an ancestor of the node - verify that the method binding doesn't already exist - use the target compilation unit rather than the compilation unit where the assist is started - modify QuickAssistProcessor.getAddMethodDeclaration() to create a special FixCorrectionProposal which specifies the target CU rather than the one in the assist context - add new test to AssistQuickFixTest1d8 - fixes #3061 * Fix modifier logic
- modify SourceAnalyzer.visit(ClassInstanceCreation) to only mark a member class as a receiver - add new tests to InlineMethodTests - fixes #3070
* Expose JUnit VM runner configuration to subclasses Allow launch delegate subclasses to reuse the fully resolved VMRunnerConfiguration without reflection or duplicating the launch orchestration. Copilot-Session: c3cd113b-dad4-4d4d-90c2-60abfd204405 Signed-off-by: wenytang-ms <wenyutang@microsoft.com> * Bump JUnit unit test feature version Update the containing feature after the org.eclipse.jdt.ui.unittest.junit bundle minor version increase. Copilot-Session: c3cd113b-dad4-4d4d-90c2-60abfd204405 Signed-off-by: wenytang-ms <wenyutang@microsoft.com> --------- Signed-off-by: wenytang-ms <wenyutang@microsoft.com>
- It shares split packages with org.eclipse.jdt.junit.core. eclipse-platform/eclipse.platform.releng.aggregator#3927
…#3063) This commit includes adding the missing Markdown code template for overrides and fixes unwanted "///" generating on types with empty params
* Fix inline method to handle local classes referencing receivers - modify SourceAnalyzer.UpdateCollector to recognize when method invocations, constructor instantiations, and field references are within a local class but are referring to methods, constructors, and fields in the receiver class instead of the local one - add new test to InlineMethodTests - fixes #3069 * Fix test failures
Member
Author
|
The ECA check is failing for #3079. |
Member
Author
|
See #3079 (comment) for the ECA check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3093.
What it does
How to test
Author checklist