Fix formatting markdown java code block with empty lines - #5267
Merged
Conversation
- fix the line start calculation in CommentsPreparator.getCodeToFormat() which assumed a blank came after the markdown opening comment but does not in the case of an empty comment - add new test to FormatterMarkdownCommentsTests - fixes eclipse-jdt#5220
jjohnstn
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
///Markdown line in code block merged with next line into/// ///#5220What it does
Fixes formatting a markdown comment with a java code block that has empty lines.
How to test
See issue or new test.
Author checklist