Skip to content

[GH-2620] consider the cursor location in completions - #3345

Closed
angelickite wants to merge 2 commits into
eclipse-jdt:masterfrom
angelickite:gh2620
Closed

[GH-2620] consider the cursor location in completions#3345
angelickite wants to merge 2 commits into
eclipse-jdt:masterfrom
angelickite:gh2620

Conversation

@angelickite

Copy link
Copy Markdown

What it does

Add cursor awareness to various auto-completion situations.

Fixes #2620 specifically and probably also bug 575025, eclipse-jdt/eclipse.jdt.ui#1804, and probably some others.

How to test

I've included some tests. A thorough description can be found in #2620.

Author checklist

@jukzi

jukzi commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

Thanks for contributing. The commit message does not match the recommendations for this repository. Please read
https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

@angelickite

Copy link
Copy Markdown
Author

Thanks for contributing. The commit message does not match the recommendations for this repository. Please read https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

I am not familiar with the options that you have for this repository but have seen that you can probably squash merge into master? So is it sufficient for me to push an empty commit that only contains the new commit message?

@jukzi

jukzi commented Nov 26, 2024 via email

Copy link
Copy Markdown
Contributor

@angelickite

Copy link
Copy Markdown
Author

I have created a new pull request: #3350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Faulty/Undesired CodeCompletion behaviour

2 participants