Template current-release versions in download pages#26108
Draft
renatsaf wants to merge 1 commit into
Draft
Conversation
Replace hardcoded "head-of-series" version literals in the download pages
with the existing ${glassfish.version.*} properties from docs/pom.xml, which
are already resolved by the website module's resource filtering. This removes
the per-release copy&paste for the latest 7.x, 7.1.x and 8.x entries.
Older release blocks stay as literals on purpose: Maven property filtering is
global, so it can only carry the current value of each series. Templating the
repeated historical blocks needs a real engine (Velocity/FreeMarker) and is
left for a follow-up.
Refs eclipse-ee4j#25503
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of #25503. Replaces the hardcoded current-release version literals in the download pages with the existing
${glassfish.version.*}properties fromdocs/pom.xml, which are already resolved by the website module's resource filtering. This removes the per-release copy&paste for the latest 7.x, 7.1.x and 8.x entries.download.md:8.0.2→${glassfish.version.8x},7.1.0→${glassfish.version.71x}download_gf7.md:7.1.0→${glassfish.version.71x},7.0.25→${glassfish.version.7x}download_gf8.md:8.0.2→${glassfish.version.8x}Rendered output is unchanged: the properties already resolve to these exact values in the build (the existing
target/classes/docs/README.mdconfirms${glassfish.version.71x}→7.1.0).Scope / why this is only Phase 1
Older release blocks (
8.0.1,8.0.0,7.0.24and below) are left as literals on purpose. Maven property filtering is global/static, so a property can only carry the current value of each series — only the latest entry per series maps to a property. The repeated historical blocks need a real templating engine with per-block variable reassignment (Velocity/FreeMarker, as discussed in the issue), which is left for a follow-up. HenceRefsrather thanFixes.Notes for reviewers
.mdfiles: they currently carry none and render directly into the published website HTML, so a header would leak into the page. Please confirm website content.mdis treated like.adoc(exempt).Refs #25503
🤖 Generated with Claude Code