Move the suntheme module from the Woodstock repository into GlassFish#26105
Open
renatsaf wants to merge 1 commit into
Open
Move the suntheme module from the Woodstock repository into GlassFish#26105renatsaf wants to merge 1 commit into
renatsaf wants to merge 1 commit into
Conversation
The woodstock-webui-jsf-suntheme module is a resource-only theme (static
assets plus a filtered MANIFEST.MF) used solely by the Admin Console. Move
it from the external glassfish-woodstock repository into a new
appserver/admingui/suntheme module so the theme and the Admin Console can
evolve together.
The module keeps its existing coordinates
(org.glassfish.woodstock:woodstock-webui-jsf-suntheme) and reproduces the
exact runtime contract: resources relocated under
com/sun/webui/jsf/suntheme and the X-SJWUIC-Theme-* manifest headers
preserved, so the console styling is unaffected. It is now built locally,
so the dependencyManagement version is repointed from ${woodstock.version}
to ${project.version}; woodstock.version still applies to
woodstock-webui-jsf and the external libraries.
Fixes eclipse-ee4j#24495
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
renatsaf
force-pushed
the
issue-24495-move-suntheme
branch
from
f6d9c3f to
c7a434f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24495
What
Moves the
woodstock-webui-jsf-sunthememodule out of the external glassfish-woodstock repository into a newappserver/admingui/sunthememodule, so the Sun theme and the Admin Console can be modified together.This is the suntheme-only move described in the issue. The module is resource-only (no Java sources): ~340 static assets (gif/jpg/png/js/css/properties/html) plus a filtered
MANIFEST.MF.Approach
appserver/admingui/sunthemeinherits the admingui parent but keeps the existing coordinatesorg.glassfish.woodstock:woodstock-webui-jsf-suntheme, so the three in-repo consumers need no dependency-declaration changes.com/sun/webui/jsf/suntheme/and theX-SJWUIC-Theme-*manifest headers preserved (timestamp filtered). Packaging isjar(notglassfish-jar) to keep the custom manifest intact.community-theme.dependencyManagementversion inappserver/pom.xmlis repointed from${woodstock.version}to${project.version}.woodstock.versionstill applies towoodstock-webui-jsfand the external libraries.Verification
com/sun/webui/jsf/suntheme/and allX-SJWUIC-Theme-*manifest headers preserved — runtime theme contract intact.community-themeresolves the locally-built8.0.3-SNAPSHOTartifact instead of the released6.0.3.Out of scope / follow-ups
glassfish-woodstockrepository is a separate PR in that repo. No clash in the meantime: GlassFish now builds and consumes its own8.0.3-SNAPSHOTsuntheme and never pulls the released6.0.3.woodstock-webui-jsfitself into GlassFish (suggested in the issue discussion) is left for a separate decision; this PR is the minimal, reversible step the issue asks for.🤖 Generated with Claude Code