Rename com.sun.enterprise.backup.util to org.glassfish.main#26102
Open
renatsaf wants to merge 1 commit into
Open
Rename com.sun.enterprise.backup.util to org.glassfish.main#26102renatsaf wants to merge 1 commit into
renatsaf wants to merge 1 commit into
Conversation
First incremental step toward refactoring GlassFish-owned com.sun.* packages to org.glassfish.main (refs eclipse-ee4j#23627). BackupUtils has no XML/config/reflection exposure and is referenced only within the appserver/admin/backup module, making it a low-risk starter for the iterative package migration. Refs eclipse-ee4j#23627 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First incremental step toward refactoring GlassFish-owned
com.sun.*packages toorg.glassfish.main, as discussed in #23627.What
Renames
com.sun.enterprise.backup.util.BackupUtilstoorg.glassfish.main.enterprise.backup.util.BackupUtilsand updates the two in-module references (BackupManager,RestoreManager).Why this class first
Per @dmatej's request in the issue, the migration should be iterative and keep every test green at each step.
BackupUtilsis the lowest-risk possible starting point:appserver/admin/backupmodule.domain.xml,*.conf,*.policy,*.properties,META-INF/services, orClass.forName— so no reflection/config exposure.The intent is to validate the per-package workflow (rename → fix imports → sweep config/string references → compile) on a trivial case before tackling larger, reflection-heavy packages.
Verification
mvn -pl appserver/admin/backup -am compilesucceeds.Refs #23627