Change Architecture section header to H3 - #499
Conversation
Signed-off-by: yamini178 <tyj2kor@bosch.com>
Error message fixed when vehicle models are browsed without signin
|
Hi @yamini178, thanks for the contribution! A few questions before we can merge this:
|
@yamini178 : requesting you to change the PR title and description to meet the actual changes. Please follow this as a standard practice to give proper headline and description for any PR you raise. @NhanLuongBGSV : The background of the change is that, when user is trying to browse ORCA without login, an unknown error was thrown. I agree for digital auto, browsing publilc models without sign in is allowed. Do we have the same strategy for ORCA? |
|
@jayantadn This setting already exists and can be changed on the Site Settings page, avoiding the need to reimplement it. ORCA contains private Bosch data, so users must log in to view it. |
|
@NhanLuongBGSV : Exactly, so model viewing without login should not be allowed. Hence the change introduced by Yamini. I guess now we have to find a way to distinguish between orca and digital.auto. @yamini178 : can you please explore this a bit? |
|
That is a misunderstanding. You are trying to implement a feature that already exists. |
|
ok, then let us discuss next week, when Yamini is in office. |
No description provided.