fix(readme): correct workflow badge extensions to .yaml#67
Merged
Conversation
GitHub Actions badge URLs must use the same extension as the workflow file. The CI workflow is `ci.yaml` and the release workflow is `release-please.yaml`; the badge URLs were pointing at `.yml` and returning 404 in the rendered README. Co-authored-by: codex@echohello.dev
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub Actions badge URLs must use the same extension as the workflow file. The CI workflow is
ci.yamland the release workflow isrelease-please.yaml. The badge URLs in the README were pointing at.ymland returning 404 in the rendered README (broken image icons in the CI/CD row).Testing
Verified both badge URLs return HTTP 200 with
image/svg+xml:https://github.com/echohello-dev/skillet/actions/workflows/ci.yaml/badge.svghttps://github.com/echohello-dev/skillet/actions/workflows/release-please.yaml/badge.svg