feat(theme): introduce semantic color tokens, light/dark, and appearance preference#9
Merged
Merged
Conversation
…nce preference - Adds AppearancePreference (system/light/dark) backed by AppStorage. - Refactors AppTheme to expose scheme-aware tokens: textPrimary/Secondary/Tertiary, cardBackground(for:), cardStroke(for:), backgroundGradient(for:), accentSurface(_:for:), shadowColor/Radius(for:). - Resolves the Classic accent from a generic .blue to a fixed RGB so all themes have deterministic colors. - Adds view modifiers: bfTextPrimary/Secondary/Tertiary and bfBackground. This is the foundation for migrating every screen to light/dark support and consistent text contrast across the five themes. Co-authored-by: opencode-agent <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppearancePreference(system/light/dark) backed by AppStorage.AppThemeto expose scheme-aware tokens:textPrimary/textSecondary/textTertiary,cardBackground(for:),cardStroke(for:),backgroundGradient(for:),accentSurface(_:for:),shadowColor/shadowRadius(for:)..blueto a fixed RGB so all themes have deterministic colors.bfTextPrimary/bfTextSecondary/bfTextTertiaryandbfBackground.This is the foundation for migrating every screen to light/dark support and consistent text contrast across the five themes (Bold, Classic, Midnight, Forest, Sunset).
Testing
mise run build: SwiftPM build completemise run test: 73 tests passmise run ios:build:dev: BUILD SUCCEEDED on iOS 26 simulator