feat(spec): add action duration metadata to manifest (Issue ebu#26)#67
Open
Richardpwe wants to merge 1 commit into
Open
feat(spec): add action duration metadata to manifest (Issue ebu#26)#67Richardpwe wants to merge 1 commit into
Richardpwe wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the manifest-based action duration metadata discussed in Issue #26.
This PR adds optional
actionDurationssupport to the Graphics manifest, schema, TypeScript definitions, and examples. Durations are expressed in milliseconds, with-1indicating a dynamic or unknown duration.playActioncan also define step-specific durations with an optional fallback entry.Notes
The implementation differs slightly from the example shape discussed in the issue:
typeinstead ofidfor the action kind, matching the existingsetActionsSchedule()action shape.customActionIdinstead ofname, becausecustomActions[].nameis already the display name, whilecustomActions[].idis the technical identifier used bycustomAction().playActiondurations use zero-based step numbers, matching the existingplayAction.gotosemantics.Closes #26.