Re-enable xarray timedelta/datetime roundtrip tests on xarray >= 2026.7.0#2297
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 88 88
Lines 38995 38995
=======================================
Hits 33030 33030
Misses 5965 5965
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
paraseba
approved these changes
Jul 24, 2026
li-em
force-pushed
the
revert-2229-timedelta-skips
branch
from
July 24, 2026 20:37
b8e80ad to
8a0b4f3
Compare
li-em
enabled auto-merge
July 24, 2026 20:40
li-em
force-pushed
the
revert-2229-timedelta-skips
branch
from
July 24, 2026 21:36
12991c4 to
122f0dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2229 skipped the xarray timedelta/datetime roundtrip tests because no released
xarray was compatible with numpy >= 2.5 time-coding (int64 * timedelta64
overflow, datetime decode failures, and a generic-unit timedelta
DeprecationWarning raised at import).
xarray 2026.7.0 ships the fix, so this re-enables the tests — but only where
the fix exists. Our minimum supported xarray (2025.07.1) still hits all of the
above when installed alongside current numpy, which is exactly what the
minimum-versions CI matrix does. A plain revert of #2229 therefore fails those
jobs (54 xarray-backends failures + 4 collection errors in
test_dask.py).Changes:
run_xarray_backends_tests.py: the three skip overrides(
test_roundtrip_timedelta_data,test_roundtrip_timedelta_data_via_dtype,test_roundtrip_numpy_datetime_data) are now defined only whenxarray < 2026.7.0. On newer xarray the upstream tests run for real.pyproject.toml: the generic-timedeltaDeprecationWarningfilter stays(old xarray raises it on import under numpy >= 2.5); it's inert on newer
xarray.
Both can be dropped once the minimum supported xarray reaches 2026.7.0.
Closes #2230