v1: fix wheel building#2144
Open
li-em wants to merge 14 commits into
Open
Conversation
…de block, r2 test - run mypy with Python 3.11 so uv resolves a zarr without PEP 695 syntax, matching mypy's python_version - backport to_icechunk mode docstring from main to match upstream xarray - use create_array instead of removed create_dataset in version-control docs - skip test_r2[public-url]: dataset at v1/era5_weatherbench2 is now v2 format - align zarr floor with main (>=3.1.0) in pyproject and CI minimum matrix
- bump minimum matrix to main's values (xarray 2025.07.1, dask/distributed 2025.2.0): xarray 2025.01.2 is incompatible with zarr 3.1.0 - cargo update anyhow (RUSTSEC-2026-0190) and crossbeam-epoch (RUSTSEC-2026-0204) - ignore quick-xml advisories as on main, and pyo3 advisories whose fix requires 0.29 (affected APIs unused)
li-em
marked this pull request as ready for review
July 24, 2026 22:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #2064
Wheel building on the
support/v1.xbranch was broken, and once that was fixed, severalother CI checks turned out to have rotted since the branch's last green run. This PR
fixes both.
Wheel building
>=1.13.1. Older maturin versions fail to build thecurrent source layout.
readmeat../README.mdinicechunk-python/pyproject.tomland bothCargo.tomlfiles. Paths outside the package directory break wheel/crate packaging;icechunk-pythongets its ownREADME.mdand theicechunkcrate uses a symlink tothe repository README.
.readthedocs.yaml(thebuild.htmlcommandhad been lost, so RTD had nothing to run).
main; drop the unmaintainedpre-commit action in favor of running
prekdirectly.RUST_CHANNELto 1.91.1 and refresh Rust dependencies.CI repairs
Everything below is drift accumulated while the branch was idle, uncovered as each layer
of CI came back to life:
the latest zarr (3.2.x), which uses PEP 695
typestatements that mypy rejects underthis branch's
python_version = "3.11". Under 3.11, uv resolves a zarr without them.to_icechunkmodedocstring frommain;upstream xarray reformatted the corresponding
to_zarrdocstring.Group.create_dataset(removed in current zarr) withGroup.create_arrayinversion-control.md. This was failing the RTD build inmkdocs strict mode.
main—zarr>=3.1.0inpyproject.tomland matchingminimum matrix pins (zarr 3.1.0, xarray 2025.07.1, dask/distributed 2025.2.0).
xarray 2025.01.2 is incompatible with zarr 3.1's dtype classes.
anyhow(RUSTSEC-2026-0190) andcrossbeam-epoch(RUSTSEC-2026-0204). Ignore the quick-xml DoS advisories (RUSTSEC-2026-0194/0195, same
rationale as
main: object_store pins quick-xml below the fixed version) and the pyo3advisories (RUSTSEC-2026-0176/0177: the fix requires pyo3 0.29, too disruptive for a
support branch, and neither affected API is used).
<4in the xarray-backends jobs; 4.x removed the--mypy-only-local-stubflag that xarray 2025.07.1's pytest config passes.main's overrides oftest_get_bytes/test_get_json(and sync variants). zarr >=3.1.6 added these to theinherited
StoreTests, writing arbitrary JSON tozarr.json, which icechunk rejectsbecause it validates metadata on write.
v1/era5_weatherbench2nowreports Icechunk v2 format, which this branch cannot open. If a v1-format copy is
restored at that prefix, the skip can be reverted.