Skip to content

fix typing errors#1433

Merged
ianhi merged 4 commits into
mainfrom
ian/typing-2
Nov 22, 2025
Merged

fix typing errors#1433
ianhi merged 4 commits into
mainfrom
ian/typing-2

Conversation

@ianhi

@ianhi ianhi commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator

after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays. So i've constrained the typing to be V3 only

@paraseba quickly, as requested :)

after zarr-developers/zarr-python#3304 we need
to be specific about if we have V2 or V3 arrays

@paraseba paraseba left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The definition of quick!

@ianhi

ianhi commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator Author

I thought it would be harder! That's why i left it out. alas it was easy once I did the barest minimum of reading release notes

@ianhi
ianhi enabled auto-merge (squash) November 21, 2025 22:37
@ianhi

ianhi commented Nov 21, 2025

Copy link
Copy Markdown
Collaborator Author

it was hard in the end :(

@ianhi
ianhi merged commit dcbd543 into main Nov 22, 2025
16 of 17 checks passed
@ianhi
ianhi deleted the ian/typing-2 branch November 22, 2025 00:31
ianhi added a commit that referenced this pull request Nov 28, 2025
after zarr-developers/zarr-python#3304 we need
to be specific about if we have V2 or V3 arrays
ianhi added a commit that referenced this pull request Nov 28, 2025
after zarr-developers/zarr-python#3304 we need
to be specific about if we have V2 or V3 arrays
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants