fix typing errors#1433
Merged
Merged
Conversation
after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays
paraseba
approved these changes
Nov 21, 2025
paraseba
left a comment
Collaborator
There was a problem hiding this comment.
The definition of quick!
Collaborator
Author
|
I thought it would be harder! That's why i left it out. alas it was easy once I did the barest minimum of reading release notes |
ianhi
enabled auto-merge (squash)
November 21, 2025 22:37
Collaborator
Author
|
it was hard in the end :( |
ianhi
added a commit
that referenced
this pull request
Nov 28, 2025
after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays
ianhi
added a commit
that referenced
this pull request
Nov 28, 2025
after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after zarr-developers/zarr-python#3304 we need to be specific about if we have V2 or V3 arrays. So i've constrained the typing to be V3 only
@paraseba quickly, as requested :)