DEV: add PipeSeparatedValue and EscapedJson support#42
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds two new regex pattern builders to the ejmask-extensions module to support masking in (1) escaped-JSON strings and (2) pipe-separated key=value payloads, and documents/validates usage via new unit tests and README updates.
Changes:
- Introduces
EscapedJsonFullValuePatternBuilderfor masking values inside escaped JSON (e.g.,{\"cvv\":\"...\"}). - Introduces
PipeSeparatedValuePatternBuilderfor masking values in pipe-delimitedkey=valuestrings. - Updates README and adds JUnit tests covering the new builders’ regex + replacement behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the two new builders and provides usage examples. |
| ejmask-extensions/src/main/java/com/ebay/ejmask/extenstion/builder/json/EscapedJsonFullValuePatternBuilder.java | Adds a builder to mask values in escaped-JSON strings. |
| ejmask-extensions/src/main/java/com/ebay/ejmask/extenstion/builder/string/PipeSeparatedValuePatternBuilder.java | Adds a builder to mask values in pipe-separated key=value payloads. |
| ejmask-extensions/src/test/java/com/ebay/ejmask/extenstion/builder/json/EscapedJsonFullValuePatternBuilderTest.java | Adds unit tests for the escaped-JSON builder. |
| ejmask-extensions/src/test/java/com/ebay/ejmask/extenstion/builder/string/PipeSeparatedValuePatternBuilderTest.java | Adds unit tests for the pipe-separated builder. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
sumanthreddybandi
approved these changes
Jun 3, 2026
hsardharaebay
approved these changes
Jun 3, 2026
prasanthkv
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The eBay payments (BES) accounting layer emits event payloads in two formats that EJMask could not previously mask:
Proposed Changes
Test Plan