Fix deployment failure by adding missing POM name and enhancing documentation#41
Merged
Merged
Conversation
prasanthkv
changed the title
There was a problem hiding this comment.
Pull request overview
Resolves Maven Central deployment failures after the migration by ensuring each published module POM declares a <name>, and improves Spring Boot integration documentation/metadata for configuration properties.
Changes:
- Added missing
<name>elements across module POMs to satisfy Maven Central publishing requirements. - Improved README Spring Boot property documentation (and added a GitHub release badge).
- Added Spring Boot
spring-configuration-metadata.jsonforejmask.*properties to improve IDE assistance.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Adds release badge; rewrites Spring Boot properties table with clearer descriptions. |
| ejmask-spring/pom.xml | Adds module POM <name> to satisfy publishing metadata requirements. |
| ejmask-spring/ejmask-spring-starter/src/main/resources/META-INF/spring-configuration-metadata.json | Adds Spring configuration metadata entries/hints for ejmask.* properties. |
| ejmask-spring/ejmask-spring-starter/pom.xml | Adds <name> for the starter artifact. |
| ejmask-spring/ejmask-spring-core/pom.xml | Adds <name> for the spring core artifact. |
| ejmask-extensions/pom.xml | Adds <name> for the extensions artifact. |
| ejmask-core/pom.xml | Adds <name> for the core artifact. |
| ejmask-bom/pom.xml | Adds <name> for the BOM artifact. |
| ejmask-api/pom.xml | Adds <name> for the API artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
RandySun228
previously approved these changes
Apr 7, 2026
prasanthkv
commented
Apr 7, 2026
RandySun228
approved these changes
Apr 7, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yvdyash
approved these changes
Apr 7, 2026
sumanthreddybandi
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Following the Maven Central migration, deployments began failing due to a missing field in the POM file.
Proposed Changes