RELEASE: 2.0.4-RELEASE#39
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project/documentation versioning for the 2.0.4 release, switching the Maven CI-friendly version suffix and updating README dependency snippets accordingly.
Changes:
- Update README dependency examples to reference
2.0.4-RELEASE. - Update Maven
pom.xmlto set<changelist>to-RELEASE(making the effective version${revision}${changelist}).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| README.md | Bumps documented Maven/Gradle coordinates to the new release version string. |
| pom.xml | Changes the Maven version suffix (<changelist>) used to form the published artifact version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| else | ||
| mvn clean deploy -s settings.xml --batch-mode -P snapshot -Dchangelist=-SNAPSHOT | ||
| fi | ||
| mvn clean deploy -s settings.xml --batch-mode -P release -Dchangelist=-RELEASE |
There was a problem hiding this comment.
Build & Deploy sets -P release but also forces -Dchangelist=-RELEASE, which overrides the release profile’s <changelist/> (empty) setting in the POM. If the intent is a standard Maven Central release version, this should typically be the plain revision (e.g., 2.0.4) and not a -RELEASE suffixed version; otherwise, consider aligning the POM’s release profile to produce -RELEASE consistently (and avoid needing to override via -Dchangelist).
| mvn clean deploy -s settings.xml --batch-mode -P release -Dchangelist=-RELEASE | |
| mvn clean deploy -s settings.xml --batch-mode -P release |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
.github/workflows/on_push_build.yml:55
- The GitHub tag/release version is derived from
<revision>only, but the Maven project version is${revision}${changelist}and this workflow also overrideschangelistduring deploy. This can create a mismatch where the GitHub tag (e.g.,v2.0.4) doesn’t correspond to the deployed artifact version. Derive the tag name from the effective Mavenproject.version(or include the same changelist used for deployment) to keep tags/releases aligned with published artifacts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ```xml | ||
| <dependency> | ||
| <groupId>com.ebay.ejmask</groupId> | ||
| <artifactId>ejmask-bom</artifactId> | ||
| <version>2.0.3</version> | ||
| <version>2.0.4-RELEASE</version> | ||
| </dependency> | ||
| ``` | ||
|
|
||
| ### Using in your Gradle Project. | ||
|
|
||
| ```groovy | ||
| compile group: 'com.ebay.ejmask', name: 'ejmask-bom', version: '2.0.3' | ||
| compile group: 'com.ebay.ejmask', name: 'ejmask-bom', version: '2.0.4-RELEASE' | ||
| ``` |
There was a problem hiding this comment.
The README now recommends using version 2.0.4-RELEASE, but the release workflow currently overrides changelist during deployment (and can produce a different effective version). Update either the documentation or the build/release versioning so the published Maven coordinates match what users are instructed to depend on.
prasanthkv
left a comment
prasanthkv
left a comment
There was a problem hiding this comment.
Having issues with -RELEASE
Pull request was closed
No description provided.