Fix concretization error with normalize_function - #101
Closed
teddykoker wants to merge 1 commit into
Closed
Conversation
ameya98
reviewed
Mar 17, 2026
| x = normalspace(1_000_001) | ||
| c = jnp.mean(phi(x) ** 2) ** 0.5 | ||
| c = c.item() | ||
| scale = jnp.where(jnp.allclose(c, 1.0), 1.0, 1.0 / c) |
Collaborator
There was a problem hiding this comment.
should we also be handling the case where c is close to 0?
Contributor
Author
There was a problem hiding this comment.
this would only be the case if the activation function was lambda x: 0 or close... figured it wasn't an issue since it wasn't in the original code either
Contributor
Author
|
Not sure if it is an issue actually, e.g. atomicarchitects/nequix#38 works fine with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e3nn_jax.activation.normalize_functioncurrently prevents shard map from working due to the.item()call. Reproducer:This change fixes.