Skip to content

Fix: forward client_decorator to the Benchling SDK#210

Merged
nirmit-damania-dyno merged 1 commit into
dynotx:mainfrom
edx4900:forward-client-decorator-timeout
Jun 16, 2026
Merged

Fix: forward client_decorator to the Benchling SDK#210
nirmit-damania-dyno merged 1 commit into
dynotx:mainfrom
edx4900:forward-client-decorator-timeout

Conversation

@edx4900

@edx4900 edx4900 commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

BenchlingService subclasses the Benchling SDK's Benchling class, whose __init__ accepts a client_decorator for customizing the underlying BenchlingApiClient. But BenchlingService.__init__ defines its own narrower signature and forwards only url, auth_method, and retry_strategy to super().__init__, so the decorator is unreachable for callers.

This PR adds an optional client_decorator parameter to BenchlingService.__init__ and forwards it to the SDK. It's backwards-compatible (defaults to None).

Closes #209

@edx4900 edx4900 changed the title Forward client_decorator to the Benchling SDK Fix: forward client_decorator to the Benchling SDK Jun 12, 2026
@nirmit-damania-dyno nirmit-damania-dyno added semver:patch A backwards compatible bug fix (patch version bump) type:minor-enhancement New minor feature or request semver:minor Added functionality in a backwards compatible manner (minor version bump) and removed semver:patch A backwards compatible bug fix (patch version bump) labels Jun 16, 2026
@nirmit-damania-dyno nirmit-damania-dyno merged commit a89e966 into dynotx:main Jun 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver:minor Added functionality in a backwards compatible manner (minor version bump) type:minor-enhancement New minor feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BenchlingService doesn't forward client_decorator / httpx_client: can't override the SDK's 10s HTTP timeout

2 participants