fix: SSRF, OOM, terminal injection, and IPv6 handling#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production hardening: context.Context, structured errors, godoc, security tests
Add context.Context as first parameter to all public API functions
Thread context through services to all network I/O (TLS dial, OCSP, CRL, HSTS, grading probes) using DialContext + HandshakeContext
Add signal-aware CLI context (graceful Ctrl+C via signal.NotifyContext)
Context-aware semaphore in CheckBatch (respects cancellation)
Define 8 structured error types (ErrConnection, ErrTLSHandshake, ErrCertificateInvalid, ErrCANotFound, ErrCAExists, ErrFileRead, ErrInvalidPEM, ErrUnsupportedProtocol) with Unwrap support
Export error types from pkg/tlsc for errors.As usage
Replace fmt.Errorf with structured errors at 12 call sites
Add godoc comments to all exported symbols (types, functions, constants, vars) across public API, domain models, and CA service
Add security control tests: isPrivateIP (20 cases), isSafeURL (7), validateURLScheme (7), ReadLimited (5), sanitize (11)
Block IPv6 tunnel addresses (6to4 2002::/16, Teredo 2001:0::/32) and all multicast in SSRF protection
Cap file reads at 1 MB via fileutil.ReadLimited (prevents OOM)
Fix PostgreSQL STARTTLS partial read (conn.Read → io.ReadFull)
Add omitempty to ValidationError JSON tag