Skip to content

Add maxlength to 255 on font selectors. Fixes: #821 #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drale1 wants to merge 1 commit into
base: 8.x
Choose a base branch
from
Open

Add maxlength to 255 on font selectors. Fixes: #821 #822

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions features/sooper-fonts/fonts-theme-settings.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ function fonts_theme_settings(array &$form, $theme) {
$form['dxpr_theme_settings']['fonts']['body_font_face_selector'] = [
'#type' => 'textfield',
'#title' => t('CSS Selector'),
'#maxlength' => 255,
'#ai_description' => 'CSS selector where the body font applies. Default body covers everything. Rarely needs changing unless you want body font only on specific elements.',
'#default_value' => ((theme_get_setting('body_font_face_selector') !== NULL)) ? theme_get_setting('body_font_face_selector') : 'body',
];
Expand All @@ -120,6 +121,7 @@ function fonts_theme_settings(array &$form, $theme) {
$form['dxpr_theme_settings']['fonts']['headings_font_face_selector'] = [
'#type' => 'textfield',
'#title' => t('CSS Selector'),
'#maxlength' => 255,
'#ai_description' => 'CSS selector for headings font. Default covers h1-h6, display classes, labels, and page title. Extend to add custom heading classes.',
'#default_value' => ((theme_get_setting('headings_font_face_selector') !== NULL)) ? theme_get_setting('headings_font_face_selector') : 'h1,.h1,h2,.h2,h3,.h3,h4,.h4,h5,.h5,h6,.h6,.display-1,.display-2,.display-3,.display-4,.display-5,.display-6,label,.field--label,.page-title',
];
Expand All @@ -135,6 +137,7 @@ function fonts_theme_settings(array &$form, $theme) {
$form['dxpr_theme_settings']['fonts']['nav_font_face_selector'] = [
'#type' => 'textfield',
'#title' => t('CSS Selector'),
'#maxlength' => 255,
'#ai_description' => 'CSS selector for navigation font. Default .dxpr-theme-header .nav targets the main menu.',
'#default_value' => ((theme_get_setting('nav_font_face_selector') !== NULL)) ? theme_get_setting('nav_font_face_selector') : '.dxpr-theme-header .nav',
];
Expand All @@ -150,6 +153,7 @@ function fonts_theme_settings(array &$form, $theme) {
$form['dxpr_theme_settings']['fonts']['sitename_font_face_selector'] = [
'#type' => 'textfield',
'#title' => t('CSS Selector'),
'#maxlength' => 255,
'#ai_description' => 'CSS selector for site name font. Default covers .site-name and .navbar-brand.',
'#default_value' => ((theme_get_setting('sitename_font_face_selector') !== NULL)) ? theme_get_setting('sitename_font_face_selector') : '.site-name, .navbar-brand',
];
Expand All @@ -165,6 +169,7 @@ function fonts_theme_settings(array &$form, $theme) {
$form['dxpr_theme_settings']['fonts']['blockquote_font_face_selector'] = [
'#type' => 'textfield',
'#title' => t('CSS Selector'),
'#maxlength' => 255,
'#ai_description' => 'CSS selector for blockquote font. Default covers blockquote and blockquote p elements.',
'#default_value' => ((theme_get_setting('blockquote_font_face_selector') !== NULL)) ? theme_get_setting('blockquote_font_face_selector') : 'blockquote, blockquote p',
];
Expand Down
Loading